fix(ui): restore inline GitHub SVG logo in author signature#23
Merged
Conversation
The 'Powered by OA Hsiao' credit icon was swapped from the inline GitHub SVG to the literal text 'GH', which rendered cramped/ugly because .gh-icon is styled for an SVG (fixed 14px box + fill + hover rotate). Restore the original inline SVG markup so it matches the existing .gh-icon CSS again. No CSS change needed. Inline SVG (~2.5KB parsed once with the DOM) adds no measurable startup time, so this reverts the cosmetic regression at zero cost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the inline GitHub SVG logo in the "Powered by OA Hsiao" author signature on the tab bar. The icon had been swapped to the literal text
GH, which looked cramped/ugly.Why it looked broken
.gh-iconin style.css is styled for an SVG — fixed14pxbox,fill: var(--text-soft), and a hoverrotate(360deg). When the markup became<span>GH</span>,fillhad no effect and the text was squeezed into a 14px box → ugly.Fix
Revert the markup back to the original inline GitHub SVG (byte-for-byte identical to the pre-swap version). No CSS change needed — the existing
.gh-iconrules already target the SVG (theme color + hover spin restored).Startup time
No measurable cost. The inline SVG is ~2.5 KB parsed once with the DOM (sub-millisecond) — not an external file, web font, or extra I/O. The original swap was an incidental, misattributed change in the "startup responsiveness" commit; the real wins there came from deferring scripts, not removing the SVG.
Files
src/renderer/index.html— restore inline<svg class="gh-icon">(1 line)Testing
--accent.